Re: Summary function for pg_buffercache
| От | Zhang Mingli |
|---|---|
| Тема | Re: Summary function for pg_buffercache |
| Дата | |
| Msg-id | 13e3e68a-8266-402e-93c2-5e126c40cc74@Spark обсуждение исходный текст |
| Ответ на | Re: Summary function for pg_buffercache (Melih Mutlu <m.melihmutlu@gmail.com>) |
| Ответы |
Re: Summary function for pg_buffercache
|
| Список | pgsql-hackers |
Hi,
On Sep 28, 2022, 22:41 +0800, Melih Mutlu <m.melihmutlu@gmail.com>, wrote:
On Sep 28, 2022, 22:41 +0800, Melih Mutlu <m.melihmutlu@gmail.com>, wrote:
Zhang Mingli <zmlpostgres@gmail.com>, 28 Eyl 2022 Çar, 17:31 tarihinde şunu yazdı:Why compute usagecount_avg twice?
I should have removed the first one, but I think I missed it.
Nice catch.
Attached an updated version.
Thanks,
Melih
Hmm, I just apply v13 patch but failed.
Part of errors:
```
error: patch failed: contrib/pg_buffercache/pg_buffercache.control:1 error: contrib/pg_buffercache/pg_buffercache.control: patch does not apply
Checking patch contrib/pg_buffercache/pg_buffercache_pages.c...
error: while searching for:
*/
PG_FUNCTION_INFO_V1(pg_buffercache_pages);
PG_FUNCTION_INFO_V1(pg_buffercache_pages_v1_4);
```
Rebase on master and then apply our changes again?
Part of errors:
```
error: patch failed: contrib/pg_buffercache/pg_buffercache.control:1 error: contrib/pg_buffercache/pg_buffercache.control: patch does not apply
Checking patch contrib/pg_buffercache/pg_buffercache_pages.c...
error: while searching for:
*/
PG_FUNCTION_INFO_V1(pg_buffercache_pages);
PG_FUNCTION_INFO_V1(pg_buffercache_pages_v1_4);
```
Rebase on master and then apply our changes again?
Regards,
Zhang Mingli
В списке pgsql-hackers по дате отправления: