Re: debugger.c tries to set log_min_messages, why?

On Tue, 2014-03-11 at 10:11 +0530, Ashesh Vashi wrote:
> Any comment? (anybody)
>

It seems good to me. It fixes the issue my customer ran into.

>
> On Sat, Mar 1, 2014 at 7:42 PM, Ashesh Vashi
> <ashesh.vashi@enterprisedb.com>wrote:
>
> > Please find the patch for the issue.
> >
> > I have changed the "SET log_min_messages TO fatal" to "SET
> > client_min_messages TO error" in the global listener connection.
> > And, removed the same line from the target invoker connection.
> >
> >
> > On Mon, Feb 10, 2014 at 10:14 PM, Guillaume Lelarge <
> > guillaume@lelarge.info> wrote:
> >
> >> On Mon, 2014-02-10 at 21:59 +0530, Ashesh Vashi wrote:
> >> > On Mon, Feb 10, 2014 at 9:54 PM, Guillaume Lelarge
> >> > <guillaume@lelarge.info>wrote:
> >> >
> >> > > On Mon, 2014-02-10 at 21:46 +0530, Ashesh Vashi wrote:
> >> > > > On Sat, Feb 8, 2014 at 10:49 PM, Guillaume Lelarge
> >> > > > <guillaume@lelarge.info>wrote:
> >> > > >
> >> > > > > Hi,
> >> > > > >
> >> > > > > Just a quick question. If you try to use the debugger, it
> >> executes a
> >> > > > > "SET log_min_messages TO fatal", which denies any regular user to
> >> debug
> >> > > > > his own functions. And actually, I don't see any reason why it
> >> should
> >> > > > > set log_min_messages. If there is, which is it?
> >> > > > >
> >> > > > When redesigning the debugger, I did not modify the existing
> >> connection
> >> > > > settings without much thoughts.
> >> > > > After reading this mail, I couldn't agree more with you. It
> >> shouldn't be
> >> > > > there.
> >> > > >
> >> > >
> >> > > Good to know. Are you working on this, or should I provide a patch?
> >> > >
> >> > I will do it.
> >> > Thanks
> >> >
> >>
> >> OK, thanks, Ashesh :)
> >>
> >>
> >> --
> >> Guillaume
> >> http://blog.guillaume.lelarge.info
> >> http://www.dalibo.com
> >>
> >>
> >
> >
> > --
> > --
> >
> > Thanks & Regards,
> >
> > Ashesh Vashi
> > EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
> >
> >
> >
> > *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
> >
>
>
>


--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com