Tom Lane <tgl@sss.pgh.pa.us> wrote:
> No, this isn't about test code vs production, it's about not bothering
> to free memory explicitly when a program is about to terminate. Alvaro
> is suggesting that the proposed addition to pg_regress.c is just a waste
> of cycles. IMO it's not that big a deal either way in this case, since
> it's just one line of code that isn't going to take too long.
Right. IMV, it's easier in this case to silence the warnings for
all future static code analysis runs, by this tool or any other, by
fixing it rather than having this particular triviality resurface
to annoy anyone in the future.
Fix pushed to the master branch.
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company