Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Magnus Hagander wrote:
>>> Maybe. I'm concerned we might end up logging a whole lot more, for cases
>>> where it's not an actual error.
I'm very concerned about that too, and think that DEBUG5 is just fine.
> Hmm, I just noticed a bug in those fprintf calls -- they are missing
> the terminating newline. Please change that too if you're going to
> patch this part of the code. In order to avoid translation problems, I
> think it should be like this:
> fprintf(stderr, _("mapped win32 error code %lu to %d" "\n"), e, errno);
That's both unreadable and useless, because gettext will smash it to one
string anyway.
regards, tom lane