Re: contrib/dblink GRANTs and regression test fix

Joe Conway <mail@joeconway.com> writes:
> The attached adds GRANTs to PUBLIC for dblink functions, removes the
> non-standard regression test, and adds standard installcheck regression test
> support.

> The test creates a second database (regression_slave) and drops it again, in
> order to avoid the cheesy-ness of connecting back to the same database ;-)

Applied.  The method for dropping the second database seems pretty
cheesy itself, though; and wouldn't it make it harder to investigate
the cause of a test failure, if one occurs?  I think I'd vote for
getting rid of the trailing wait() and DROP and instead doing

\set ECHO none
DROP DATABASE regression_slave;
\set ECHO all
CREATE DATABASE regression_slave;

at the top.

            regards, tom lane