On Fri, 2013-01-04 at 11:57 +0100, Guillaume Lelarge wrote:
> On Fri, 2012-12-28 at 23:52 +1100, Evan Martin wrote:
> > I think Ctrl-R is good for refresh (like Firefox and other browsers) and
> > Ctrl-Shift-C sounds fine, too.
>
> OK.
>
> > For Cancel Query I'd suggest "Del" - it "deletes" the process.
> > For Terminate backend: Shift-Del - it "really delets" it, like pressing
> > Shift-Del in Windows Explorer bypasses the Recycling Bin.
>
> OK.
>
> > Not sure about the commit/rollback buttons, but maybe Ctrl-S (save) for
> > commit and Ctrl-Z (undo) for rollback?
> >
>
> Ctrl-Z is explicitely to handle undo on the UI. We don't use it here,
> but for consistency sake, we won't use it for anything else.
>
> > It's not immediately clear what the different between Edit, Copy and
> > Action, Copy is. Maybe rename Action, Copy to "Copy to query tool" or
> > something?
> >
>
> Seems fine to me.
>
I can commit this anytime soon. Just tell me if you want to test it
first.
> > I tested the "clear selection" thing. The selection is cleared when the
> > selected process terminates and the cancel/terminate toolbar buttons
> > don't do anything then, but they are still enabled. Would be nice to
> > actually grey them out. Action, Copy also remains enabled and selecting
> > that causes a segfault.
> >
>
> This needs to get fixed. Working on it.
>
Fixed. Thanks for your report.
--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com