Re: [PATCHES] [pgsql-patches] Phantom Command IDs,updated patch

Alvaro Herrera <alvherre@commandprompt.com> writes:
> Simon Riggs wrote:
>> Combo is OK, because it's a *combination* of two CommandIds. 
>> 
>> That means they are ComboCommandIds or CCIs.

> CCI is CommandCounterIncrement to me, so let's not use that
> abbreviation.

Agreed.  I looked for a bit at adding a separate typedef ComboCommandId
to be used where a cid was definitely a combo cid, but it didn't seem to
be very useful to do that...

I'm testing the patch currently.  I was a bit surprised to find the
without_oid test failing, but it makes sense because I'm using a
MAXALIGN=8 machine.  I suppose Heikki tested on MAXALIGN=4.
        regards, tom lane