Re: [PATCH] Improve safety of FormatMessage() calls on Windows

Christian Ullrich <chris@chrullrich.net> writes:
> There are some instances of calls to FormatMessage() with the 
> FORMAT_MESSAGE_FROM_SYSTEM flag that omit the 
> FORMAT_MESSAGE_IGNORE_INSERTS flag. The effect of that is that if the 
> requested message string contains any insertion markers, the call to 
> FormatMessage() will fail because none of these calls pass an argument list.

> This patch adds the ...IGNORE_INSERTS flag to these calls.

Good catch, pushed (with some cosmetic reformatting).
        regards, tom lane