Re: compiler warnings on the buildfarm

Heikki Linnakangas <heikki@enterprisedb.com> writes:
> FWIW, this patch makes the warnings go away, and makes the code a little 
> bit more readable as well. It would be nice to understand why exactly 
> it's complaining, though.

Let's apply the patch.  We are clearly tickling a bug or near-bug in
gcc, and it may have worse consequences than this on other platforms
or other gcc versions.

At the same time, if anyone wants to trim the existing code down to a
small test case, I'm sure the gcc boys would appreciate a bug report.
        regards, tom lane