Re: Cannot find a working 64-bit integer type on Illumos

Daniel Gustafsson <daniel@yesql.se> writes:
>> On 26 Mar 2025, at 00:01, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> How did that work before?  Perhaps somebody just now added a libpq
>> dependency to pg_regress.c?

> I believe the libpq dependency came in 66d6086cbcbfc8 which wasn't all that
> recent.

It looks like this has been broken for a very long time, but it must
never have mattered before because libpq-fe.h is so stable, and
pg_regress doesn't use any new-ish APIs from it.  So pulling in
whatever version the platform had still worked.

I think this should work to fix it:

-pg_regress.o: override CPPFLAGS += -I$(top_builddir)/src/port -I$(libpq_srcdir) $(EXTRADEFS)
+pg_regress.o: override CPPFLAGS := -I$(top_builddir)/src/port -I$(libpq_srcdir) $(EXTRADEFS) $(CPPFLAGS)

but I haven't tested yet.

            regards, tom lane