On fre, 2012-05-11 at 11:28 +0200, Jan Urbański wrote:
> On 10/05/12 19:45, Peter Eisentraut wrote:
> > On lör, 2012-05-05 at 22:45 +0200, Jan Urbański wrote:
> >> Apparently once you implement PyMappingMethods.mp_subscript you can
> >> drop PySequenceMethods.sq_slice, but I guess there's no harm in
> >> keeping it (and I'm not sure it'd work on Python 2.3 with only
> >> mp_subscript implemented).
> >
> > Committed this now.
> >
> > From test coverage reports, I now see that PLy_result_ass_item() is no
> > longer called. That's probably OK, if assignments are now handled
> > through the mapping methods. But should we remove the function then?
>
> Have you tried on Python 2.3 as well? People on #python said that if you
> implement the mapping functions, the sequence slicing functions are no
> longer used, but maybe we should revisit for the next release, rather
> than risk introducing a regression for the benefit of removing a few
> dead lines.
I did test Python 2.3, but you're right, we should leave this alone
during beta.