Re: pgsql: pg_logicalinspect: Fix possible crash when passing a directory p

David Rowley <dgrowleyml@gmail.com> writes:
> On Thu, 17 Jul 2025 at 02:56, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Looking again at the code for ereport_domain(), I wondered if
>> something like this would help MSVC see through it:

> I tried this and it unfortunately doesn't fix the issue.

I didn't have huge hopes for that, but thanks for checking.

> I spent a bit more time searching for a solution and did find
> something that works well enough for this case in [1]. Unfortunately,
> it only works with C11. See attached .c file and output below.

Hmph.  I doubt we are ready to require C11 everywhere, but maybe
we could require it in MSVC builds?  Which MSVC versions would
that eliminate?

            regards, tom lane