Re: Potential reference miscounts and segfaults in plpython.c

On sön, 2012-02-19 at 22:29 -0500, Tom Lane wrote:
> My only comment is whether elog(ERROR) is appropriate, ie, do we
> consider these to be internal errors that users will never see in
> practice? If there's a significant risk of the error being thrown in
> the field, it might be better to use ereport, to expose the message
> for translation.

I find the wording of the error messages a bit inappropriate.  For
example,
       list = PyList_New(length);
+       if (list == NULL)
+               elog(ERROR, "could not transform Python list to array");

The error is not about the transforming, it's about creating a new list.