Robert Haas <robertmhaas@gmail.com> writes:
> The problem isn't confined to CREATE TABLE LIKE; it's a widespread
> design flaw that will likely take years of work to clean up
> completely. I don't think that's a reason not to commit your change
> though; it fixes a bug and is an incremental improvement, even if a
> small one. That having been said, if you're feeling an urge to tackle
> the problem more broadly, don't let me stand in your way...
Not me; I'm just trying to close out a bug report.
FWIW, I think your argument only barely supports this change at all,
because CREATE TABLE LIKE is still generating an IndexStmt which after
all is the representation of a CREATE INDEX command. We've overloaded
it to do a few other things, and now it will be able to do one more
thing, but this isn't moving things at all towards separating high-
and low-level operations.
regards, tom lane