Re: REGRESS_OPTS default

On tis, 2011-08-23 at 21:17 -0400, Tom Lane wrote:
> There are at least two ways we could fix this: change
> earthdistance/Makefile to do this:
> 
> REGRESS_OPTS = --extra-install=contrib/cube --dbname=$(CONTRIB_TESTDB)
> 
> or change pgxs.mk to do this:
> 
> REGRESS_OPTS += --dbname=$(CONTRIB_TESTDB)
> 
> I'm leaning towards the latter as being less prone to mistakes of
> omission.  If there's some reason for a pgxs-using makefile to
> override
> the target DB name, it can set CONTRIB_TESTDB instead of messing with
> REGRESS_OPTS.

I like the latter solution as well.