Re: Compiler warnings with stringRelOpts (was WIP: Fast GiST index build)

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: Compiler warnings with stringRelOpts (was WIP: Fast GiST index build)
Дата
Msg-id 1312818141-sup-4754@alvh.no-ip.org
обсуждение исходный текст
Ответ на Compiler warnings with stringRelOpts (was WIP: Fast GiST index build)  (Alexander Korotkov <aekorotkov@gmail.com>)
Ответы Re: Compiler warnings with stringRelOpts (was WIP: Fast GiST index build)  (Alexander Korotkov <aekorotkov@gmail.com>)
Список pgsql-hackers
Excerpts from Alexander Korotkov's message of lun ago 08 06:27:33 -0400 2011:
> String-formatted relopts was never used before, but I've used it in
> buffering GiST index build patch and encountered with following compiler
> warnings:
> 
> reloptions.c:259: warning: initializer-string for array of chars is too long
> reloptions.c:259: warning: (near initialization for
> ‘stringRelOpts[0].default_val’**)
> 
> It is caused by definition of default field of relopt_string structure as
> 1-length character array. This seems to be a design flaw in the reloptions.c
> code. Any thoughts?

Maybe this needs to use the new FLEXIBLE_ARRAY_MEMBER stuff.  Can you try that please?

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Florian Pflug
Дата:
Сообщение: Re: WIP fix proposal for bug #6123
Следующее
От: Alexander Korotkov
Дата:
Сообщение: Re: Compiler warnings with stringRelOpts (was WIP: Fast GiST index build)