Re: SSI error messages

On lör, 2011-07-16 at 21:55 +0300, Heikki Linnakangas wrote:
> I think I would prefer something like this:
> 
> ERROR:  could not serialize access due to read/write dependencies
> among 
> transactions
> DETAIL: Reason code: %s
> HINT:  The transaction might succeed if retried.
> 
> Where %s gets the current detail field, untranslated, like:
> 
> Canceled on commit attempt with conflict in from prepared pivot.

Do you have an idea how to address this case:

@@ -3865,7 +3865,7 @@ CheckForSerializableConflictOut(bool visible, Relation relation,               ereport(ERROR,
                 (errcode(ERRCODE_T_R_SERIALIZATION_FAILURE),                        errmsg("could not serialize access
dueto read/write dependencies among transactions"),
 
-                        errdetail_internal("Canceled on conflict out to old pivot %u.", xid),
+                        errdetail("Reason code: %s.", "canceled on conflict out to old pivot %u", xid),  // XXX bogus
                  errhint("The transaction might succeed if retried.")));           if
(SxactHasSummaryConflictIn(MySerializableXact)