On Sun, 2011-06-26 at 20:29 +0100, Dave Page wrote:
> On Sat, Jun 25, 2011 at 3:50 PM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
> > On Sat, 2011-06-25 at 15:51 +0200, Guillaume Lelarge wrote:
> >> On Sat, 2011-06-25 at 12:18 +0200, Guillaume Lelarge wrote:
> >> > [...]
> >> > Dave, any objection on applying the current work of Luis? I'll work this
> >> > afternoon on the xpm files, I should be able to send a patch after that.
> >> >
> >>
> >> Branch available here:
> >>
> >> https://github.com/gleu/pgadmin3/tree/gsoc2011
> >>
> >> Patches attached (they will be applied as one).
> >>
> >
> > And here are the changes on the VC++ project file.
> >
> > Waiting for comments before applying :)
>
> Hi,
>
> Sorry - in the late stages of my current project, so I'm swamped with
> testing/QA/docs/you name it! I won't be able to review, but trust you
> to do so Guillaume.
OK, thanks.
> The one comment I would make from the thread is
> that I don't think the code should be committed without the XRC
> changes you mention. If that's not done before it's committed, I doubt
> it ever will be.
>
I don't want that Luis lost some time working on the XRC files. And I
don't want him to get stuck before I do it. So, I commited the patch,
and pushed it, so that he could work from the new master. And I'll work
on the XRC files tonight.
--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com