Peter Geoghegan <pg@bowt.ie> writes:
> On Wed, Feb 27, 2019 at 1:27 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> OID collision doesn't seem to be a significant problem (for me).
>> Um, I beg to differ. It's not at all unusual for pending patches to
>> bit-rot for no reason other than suddenly getting an OID conflict.
>> I don't have to look far for a current example:
>> https://travis-ci.org/postgresql-cfbot/postgresql/builds/498955351
> Patch authors shouldn't be left with any excuse for leaving their
> patch to bitrot for long. And, more casual patch reviewers shouldn't
> have any excuse for not downloading a patch and applying it locally,
> so that they can spend a spare 10 minutes kicking the tires.
Yeah, that latter point is really the killer argument. We don't want
to make people spend valuable review time on fixing uninteresting OID
conflicts. It's even more annoying that several people might have to
duplicate the same work, if they're testing a patch independently.
Given a convention that under-development patches use OIDs in the 9K
range, the only time anybody would have to resolve OID conflicts for
testing would be if they were trying to test the combination of two
or more patches. Even then, an OID-renumbering script would make it
pretty painless: apply patch 1, renumber its OIDs to someplace else,
apply patch 2, repeat as needed.
> Why not have unused_oids reference the convention as a "tip"?
Hmm, could be helpful.
regards, tom lane