Re: assertion failure w/extended query protocol
От
Tom Lane
Тема
Re: assertion failure w/extended query protocol
Дата
Msg-id
13031.1350686274@sss.pgh.pa.us
Ответ на
Re: assertion failure w/extended query protocol (Andres Freund)
Список
Дерево обсуждения
assertion failure w/extended query protocol Robert Haas <robertmhaas@gmail.com>
Re: assertion failure w/extended query protocol Peter Geoghegan <peter@2ndquadrant.com>
Re: assertion failure w/extended query protocol Andres Freund <andres@2ndquadrant.com>
Re: assertion failure w/extended query protocol Andres Freund <andres@2ndquadrant.com>
Re: assertion failure w/extended query protocol Tom Lane <tgl@sss.pgh.pa.us>
Re: assertion failure w/extended query protocol Andres Freund <andres@2ndquadrant.com>
Re: assertion failure w/extended query protocol Tom Lane <tgl@sss.pgh.pa.us>
Re: assertion failure w/extended query protocol Andres Freund <andres@2ndquadrant.com>
Re: assertion failure w/extended query protocol Robert Haas <robertmhaas@gmail.com>
Re: assertion failure w/extended query protocol Tom Lane <tgl@sss.pgh.pa.us>
Re: assertion failure w/extended query protocol Andres Freund <andres@2ndquadrant.com>
Re: assertion failure w/extended query protocol Tom Lane <tgl@sss.pgh.pa.us>
Re: assertion failure w/extended query protocol Rushabh Lathia <rushabh.lathia@gmail.com>
Re: assertion failure w/extended query protocol Robert Haas <robertmhaas@gmail.com>
Re: assertion failure w/extended query protocol Andrew Dunstan <andrew@dunslane.net>
Re: assertion failure w/extended query protocol Tom Lane <tgl@sss.pgh.pa.us>
Re: assertion failure w/extended query protocol Peter Geoghegan <peter@2ndquadrant.com>
Andres Freund writes:
> So as far as I can see the new logic is correct? A quick look & test seems to
> confirm that.
I think the real problem here is just that the code was trying to be too
specific, and while your version might be more correct it's not doing
anything to fix that misjudgment. We should just make the
CreateTableAsStmt case look like the ExplainStmt case, viz
Assert(IsA(qry, Query)); if (qry->commandType == CMD_UTILITY) return UtilityContainsQuery(qry->utilityStmt); return qry;
regards, tom lane
В списке pgsql-hackers по дате отправления
От: Andres Freund
Дата: