Re: generic reloptions improvement

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: generic reloptions improvement
Дата
Msg-id 1301.1231112228@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: generic reloptions improvement  (Alvaro Herrera <alvherre@commandprompt.com>)
Список pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes:
> This is the patch in its final form.  I have included a few macros to
> simplify the writing of amoptions routines.

Minor gripes:

* Does initialize_reloptions() need to be exported?  It seems to be
only called within parseRelOptions().  It's far from clear who else
should be expected to call it.

* The HANDLE_ macros are dangerous as-is (dangling if/else).  Need to
use the usual do/while trick.
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Alex Hunsaker"
Дата:
Сообщение: [PATCH] ALTER TABLE SET (compress_max_size... = )
Следующее
От: "Hitoshi Harada"
Дата:
Сообщение: Re: WIP patch for basic window frame support