Hi,
Found a couple of small typos in the comments of nodeWindowAgg.c when
they refer to functions in nodeAgg.c. The pluralities of the function
names (initialize_aggregates and advance_aggregates) are wrong. The
reference to "finalize_aggregate" is correct though.
diff --git a/src/backend/executor/nodeWindowAgg.c
b/src/backend/executor/nodeWindowAgg.c
index c3efe12..51f98c1 100644
*** a/src/backend/executor/nodeWindowAgg.c
--- b/src/backend/executor/nodeWindowAgg.c
*************** static bool window_gettupleslot(WindowOb
*** 181,187 **** /* * initialize_windowaggregate
! * parallel to initialize_aggregate in nodeAgg.c */ static void initialize_windowaggregate(WindowAggState
*winstate,
--- 181,187 ---- /* * initialize_windowaggregate
! * parallel to initialize_aggregates in nodeAgg.c */ static void initialize_windowaggregate(WindowAggState
*winstate,
*************** initialize_windowaggregate(WindowAggStat
*** 207,213 **** /* * advance_windowaggregate
! * parallel to advance_aggregate in nodeAgg.c */ static void advance_windowaggregate(WindowAggState *winstate,
--- 207,213 ---- /* * advance_windowaggregate
! * parallel to advance_aggregates in nodeAgg.c */ static void advance_windowaggregate(WindowAggState *winstate,
Regards,
Andreas Karlsson