On ons, 2010-11-17 at 21:05 +0100, Dimitri Fontaine wrote:
> Code wise, though, I wonder about the name of the "recursing"
> parameter of the renameatt_internal function is
> src/backend/commands/tablecmds.c,
> which seems to only get used to detect erroneous attempt at renaming
> the table column directly. Maybe it's only me not used enough to
> PostgreSQL code yet, but here it distract the code reader. Having
> another parameter called "recurse" is not helping, too, but I don't
> see this one needs to be changed.
This parameter has only minimal use in the renameatt case, but the same
terminology is used throughout the ALTER TABLE code, so I think it's
wise to keep it.