Re: pg_basebackup failed to back up large file
| От | Tom Lane |
|---|---|
| Тема | Re: pg_basebackup failed to back up large file |
| Дата | |
| Msg-id | 12852.1401806455@sss.pgh.pa.us обсуждение исходный текст |
| Ответ на | Re: pg_basebackup failed to back up large file (Andres Freund <andres@2ndquadrant.com>) |
| Ответы |
Re: pg_basebackup failed to back up large file
|
| Список | pgsql-hackers |
Andres Freund <andres@2ndquadrant.com> writes:
> On 2014-06-03 23:19:37 +0900, Fujii Masao wrote:
>> - if (sscanf(copybuf + 124, "%11o", ¤t_len_left) != 1)
>> + if (sscanf(copybuf + 124, "%11lo", ¤t_len_left) != 1)
> That's probably not going to work on 32bit platforms or windows where
> you might need to use ll instead of l as a prefix. Also notice that
> apparently (c.f. 9d7ded0f4277f5c0063eca8e871a34e2355a8371) sscanf can't
> reliably be used for 64bit input :(. That pretty much sucks...
There's a far bigger problem there, which is if we're afraid that
current_len_left might exceed 4GB then what is it exactly that guarantees
it'll fit in an 11-digit field?
regards, tom lane
В списке pgsql-hackers по дате отправления: