Re: page corruption on 8.3+ that makes it to standby
От | Simon Riggs |
---|---|
Тема | Re: page corruption on 8.3+ that makes it to standby |
Дата | |
Msg-id | 1280314950.1878.4667.camel@ebony обсуждение исходный текст |
Ответ на | Re: page corruption on 8.3+ that makes it to standby (Jeff Davis <pgsql@j-davis.com>) |
Ответы |
Re: page corruption on 8.3+ that makes it to standby
|
Список | pgsql-hackers |
On Tue, 2010-07-27 at 21:23 -0700, Jeff Davis wrote: > Both potential fixes attached and both appear to work. > > fix1 -- Only call PageSetLSN/TLI inside log_newpage() and > heap_xlog_newpage() if the page is not zeroed. > > fix2 -- Don't call log_newpage() at all if the page is not zeroed. > > Please review. I don't have a strong opinion about which one should be > applied. ISTM we should just fix an uninitialized page first, using code from VACUUM similar to if (PageIsNew(page)) { ereport(WARNING,(errmsg("relation \"%s\" page %u is uninitialized --- fixing", relname, blkno))); PageInit(page, BufferGetPageSize(buf), 0); } then continue as before. We definitely shouldn't do anything that leaves standby different to primary. -- Simon Riggs www.2ndQuadrant.comPostgreSQL Development, 24x7 Support, Training and Services
В списке pgsql-hackers по дате отправления: