Re: need more ALTER TABLE guards for typed tables

Поиск
Список
Период
Сортировка
От Peter Eisentraut
Тема Re: need more ALTER TABLE guards for typed tables
Дата
Msg-id 1279827247.16475.0.camel@vanquo.pezone.net
обсуждение исходный текст
Ответ на Re: need more ALTER TABLE guards for typed tables  (Alvaro Herrera <alvherre@commandprompt.com>)
Список pgsql-hackers
On ons, 2010-07-21 at 15:48 -0400, Alvaro Herrera wrote:
> Excerpts from Peter Eisentraut's message of mié jul 21 15:18:58 -0400 2010:
> > After some investigation I figured that I need to add two more checks
> > into the ALTER TABLE code to prevent certain types of direct changes to
> > typed tables (see attached patch).
> >
> > But it's not clear to me whether such checks should go into the "Prep"
> > or the "Exec" phases.  Prep seems more plausible to me, but some
> > commands such as DropColumn don't have a Prep handler.  A clarification
> > would be helpful.
>
> I think if there's no Prep phase, you should add it.  I don't think it
> makes sense to have this kind of check in Exec.

OK, here is my patch for this.  (should go into 9.0 and 9.1)


Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Kevin Grittner"
Дата:
Сообщение: Re: [RRR] CommitFest 2010-07 week one progress report
Следующее
От: Peter Eisentraut
Дата:
Сообщение: Re: [9.1] pg_stat_get_backend_server_addr