Re: Replication server timeout patch

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Replication server timeout patch
Дата
Msg-id 12760.1301405089@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Replication server timeout patch  (Fujii Masao <masao.fujii@gmail.com>)
Ответы Re: Replication server timeout patch  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
Fujii Masao <masao.fujii@gmail.com> writes:
> On Mon, Mar 28, 2011 at 7:49 PM, Heikki Linnakangas
>> Should we use COMMERROR instead of ERROR if we fail to put the socket in the
>> right mode?

> Maybe.

COMMERROR exists to keep us from trying to send an error report down a
failed socket.  I would assume (perhaps wrongly) that
walsender/walreceiver don't try to push error reports across the socket
anyway, only to the postmaster log.  If correct, there is no need for
COMMERROR, and using it just muddies the code.
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: deadlock_timeout at < PGC_SIGHUP?
Следующее
От: "Kevin Grittner"
Дата:
Сообщение: Re: SSI bug?