Re: Stefan's bug (was: max_standby_delay considered harmful)
От | Simon Riggs |
---|---|
Тема | Re: Stefan's bug (was: max_standby_delay considered harmful) |
Дата | |
Msg-id | 1274160419.28911.1586.camel@ebony обсуждение исходный текст |
Ответ на | Re: Stefan's bug (was: max_standby_delay considered harmful) (Fujii Masao <masao.fujii@gmail.com>) |
Ответы |
Re: Stefan's bug (was: max_standby_delay considered harmful)
|
Список | pgsql-hackers |
On Tue, 2010-05-18 at 12:02 +0900, Fujii Masao wrote: > On Mon, May 17, 2010 at 9:01 PM, Simon Riggs <simon@2ndquadrant.com> wrote: > >> (1) > >> Smart or fast shutdown requested in PM_STARTUP state always removes > >> the backup_label file if it exists. But it might be still required > >> for subsequent recovery. I changed your patch so that additionally > >> the postmaster skips deleting the backup_label in that case. > > > > Don't like the name NeedBackupLabel seems too specific. That really > > corresponds to "we were in recovery". We should have a couple of > > super-states that correspond to am in recovery/am not in recovery so we > > can drive it from that. > > ISTM that we can use XLogCtl->SharedRecoveryInProgress for that. > Is this OK? That can change state at any time. Would that work? -- Simon Riggs www.2ndQuadrant.com
В списке pgsql-hackers по дате отправления: