Re: pgsql: Fix (some of the) breakage introduced into query-cancel
От | Simon Riggs |
---|---|
Тема | Re: pgsql: Fix (some of the) breakage introduced into query-cancel |
Дата | |
Msg-id | 1262897209.19367.89795.camel@ebony обсуждение исходный текст |
Ответ на | Re: pgsql: Fix (some of the) breakage introduced into query-cancel (Tom Lane <tgl@sss.pgh.pa.us>) |
Ответы |
Re: pgsql: Fix (some of the) breakage introduced into query-cancel
|
Список | pgsql-committers |
On Thu, 2010-01-07 at 15:29 -0500, Tom Lane wrote: > Simon Riggs <simon@2ndquadrant.com> writes: > > On Thu, 2010-01-07 at 16:29 +0000, Tom Lane wrote: > >> Fix (some of the) breakage introduced into query-cancel processing by HS. > > >> It is absolutely not okay to throw an ereport(ERROR) in any random place in > >> the code just because DoingCommandRead is set; interrupting, say, OpenSSL > >> in the midst of its activities is guaranteed to result in heartache. > > > ...That was not introduced by HS. > > Yes it was; or at least it was in your HS commit: > > http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/tcop/postgres.c.diff?r1=1.578;r2=1.579 Ah, you were referring to those lines. I thought you were referring to the additional lines you put in around ClientAuthInProgress. -- Simon Riggs www.2ndQuadrant.com
В списке pgsql-committers по дате отправления: