Re: Hot standby, misc issues

On Fri, 2009-12-04 at 10:23 +0200, Heikki Linnakangas wrote:
> 
> > @Heikki: Why is error checking in KnownAssignedXidsRemove() #ifdef'd
> out?? 
> 
> It's explained in the comment:
> /* XXX: This can still happen: If a transaction with a subtransaction
>  * that haven't been reported yet aborts, and no WAL records have been
>  * written using the subxid, the abort record will contain that subxid
>  * and we haven't seen it before.
>  */

Just realised that this occurs again because the call to
RecordKnownAssignedTransactionIds() was removed from
xact_commit_abort().

I'm guessing you didn't like the call in that place for some reason,
since I smile while I remember it has been removed twice(!) even though
I put "do not remove" comments on it to describe this corner case.

Not going to put it back a third time.

-- Simon Riggs           www.2ndQuadrant.com