Re: BUG #4879: bgwriter fails to fsync the file in recovery mode

On Thu, 2009-06-25 at 19:20 +0300, Heikki Linnakangas wrote:
> Simon Riggs wrote:
> >

> But we need to set LocalRecoveryInProgress appropriately
> > also.
>
> Yeah, the trouble is to tell bgwriter that it's OK for it to create the
> checkpoint, which includes writing a WAL record, while still keeping the
> system "in-recovery" for all other purposes. While we could just relax
> the checks, that seems like a very important safeguard.
>
> (I posted in the other mail to do a restartpoint before the startup
> process does the checkpoint)

I think we're in strong agreement, just thinking and writing emails in
realtime gives a few race conditions... your patch covers everything I
mentioned above.

--
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support