Re: WIP: Fix invalid XML explain plans for track_io_timing

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: WIP: Fix invalid XML explain plans for track_io_timing
Дата
Msg-id 12377.1476998541@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: WIP: Fix invalid XML explain plans for track_io_timing  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
I wrote:
> Markus Winand <markus.winand@winand.at> writes:
>> The XML output of explain potentially outputs the XML tag names "I/O-Write-Time"
>> and "I/O-Read-Time", which are invalid due to the slash.

> Ooops.

After further thought I decided we should go with the whitelist solution.
The extra time needed to produce XML-format output isn't really likely to
bother anyone.  And given that this bug escaped notice for several years,
it seems likely that the next time somebody decides to be creative about
picking a tag name, we might not notice an XML syntax violation for
several more years.  So a future-proof fix seems advisable.

I pushed a patch using the strchr() approach.  Thanks for reporting this!
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Stephen Frost
Дата:
Сообщение: Re: Improve output of BitmapAnd EXPLAIN ANALYZE
Следующее
От: Merlin Moncure
Дата:
Сообщение: Re: emergency outage requiring database restart