Re: pgsql: Small stylistic improvement in recent FORCE QUOTE * code - use a

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: pgsql: Small stylistic improvement in recent FORCE QUOTE * code - use a
Дата
Msg-id 12355.1248541671@sss.pgh.pa.us
обсуждение исходный текст
Ответ на pgsql: Small stylistic improvement in recent FORCE QUOTE * code - use a  (adunstan@postgresql.org (Andrew Dunstan))
Ответы Re: pgsql: Small stylistic improvement in recent FORCE QUOTE * code - use a
Список pgsql-committers
adunstan@postgresql.org (Andrew Dunstan) writes:
> Log Message:
> -----------
> Small stylistic improvement in recent FORCE QUOTE * code - use a bool instead of a magic value.

This actually broke things a bit.  I agree that the original coding with
a phony list header was horridly ugly, but it did have one redeeming
value: namely that the various existing tests for force_quote not empty
still worked as-is.  With the separate bool you need to extend all those
checks.  On balance it still seems cleaner that way, though, so I made
the necessary fixes.

            regards, tom lane

В списке pgsql-committers по дате отправления:

Предыдущее
От: tgl@postgresql.org (Tom Lane)
Дата:
Сообщение: pgsql: Code review for FORCE QUOTE * patch: fix error checking to
Следующее
От: Andrew Dunstan
Дата:
Сообщение: Re: pgsql: Small stylistic improvement in recent FORCE QUOTE * code - use a