Re: Hot standby, recovery infra

On Thu, 2009-01-29 at 10:36 +0900, Fujii Masao wrote:
> Hi,
> 
> On Wed, Jan 28, 2009 at 11:19 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
> >> I feel quite good about this patch now. Given the amount of code churn, it
> >> requires testing, and I'll read it through one more time after sleeping over
> >> it. Simon, do you see anything wrong with this?
> >
> > I also read this patch and found something odd. I apologize if I misread it..
> 
> If archive recovery fails after it reaches the last valid record
> in the last unfilled WAL segment, subsequent recovery might cause
> the following fatal error. This is because minSafeStartPoint indicates
> the end of the last unfilled WAL segment which subsequent recovery
> cannot reach. Is this bug? (I'm not sure how to fix this problem
> because I don't understand yet why minSafeStartPoint is required.)
> 
> > FATAL:  WAL ends before end time of backup dump

I think you're right. We need a couple of changes to avoid confusing
messages.

-- Simon Riggs           www.2ndQuadrant.comPostgreSQL Training, Services and Support