Re: [PATCH] reloptions - RELOPT_KIND_ALL

Alvaro Herrera píše v pá 23. 01. 2009 v 11:14 -0300:
> Zdenek Kotala wrote:
> > 
> > Alvaro Herrera píše v pá 23. 01. 2009 v 11:04 -0300:
> > > Zdenek Kotala wrote:
> > > > I attached patch which add capability to have single record for all
> > > > realation kind in the reloption list. It is usefull in situation when
> > > > all parameters are same for all relation kinds.
> > > 
> > > Do you have an example use case for this?
> > 
> > I use it in my space reservation patch. I going to send it soon. The
> > default value is zero in all relkind and max value as well. It seems to
> > me waste a space to copy and paste same lines several times.
> 
> Hmm, but is it really applicable to all relkinds?  Is it applicable to
> GIN indexes for example?  Keep in mind that GIN does not even have
> fillfactor.  How are you going to make space reservation work for GIN?

Yes it is. I need two new reloptions - rs_perpage and rs_pertuple. I
don't use fillfactor. I modified PageGetFreeSpace function to return
correct value.

These two options are applicable on all relkind (including toast*) which
use standard page layout - currently all AM.        Zdenek

* I know that toast is not supported yet.