Re: Latest version of Hot Standby patch

On Wed, 2009-01-07 at 23:56 +0200, Heikki Linnakangas wrote:
> Simon Riggs wrote:
> > On Wed, 2009-01-07 at 15:43 +0200, Heikki Linnakangas wrote:
> >> When there's no xids in the procarray, couldn't we just use 
> >> latestCompletedXid instead of calling ReadNewTransactionId()?
> > 
> > latestCompletedXid is protected by ProcArrayLock so not much difference
> > between those two.
> 
> The big difference is that we're already holding ProcArrayLock. You 
> could read the value of latestCompletedXid before releasing 
> ProcArrayLock, and wouldn't need the retry logic.

Sounds good to me then. Will rework.

-- Simon Riggs           www.2ndQuadrant.comPostgreSQL Training, Services and Support