Peter Eisentraut <peter_e@gmx.net> writes:
> Let me point out again that my patch doesn't actually do anything about
> PGDLLEXPORT or the like. It just adds automatic prototypes into
> PG_FUNCTION_INFO_V1, to reduce compiler warnings in extensions and
> reduce some boilerplate in general.
Hmm ... for some reason I had gotten it in my head that you were adding
PGDLLEXPORT to the autogenerated extern declarations, but at least the
version of the patch in <1389762012.24046.2.camel@vanquo.pezone.net>
doesn't do that, so the point is moot.
I still object to the aspect of the patch that moves the externs for
_PG_init/_PG_fini into fmgr.h: that is conceptually wrong and will create
more confusion than the trivial code savings is worth. But I won't
complain if you commit the PG_FUNCTION_INFO_V1 changes.
regards, tom lane