On Fri, 2008-11-21 at 13:22 +0530, Pavan Deolasee wrote:
>
> I think we should avoid the #define's like below which uses a local
> variable. I guess the same #define is used elsewhere in the code as
> well. If the code is rearranged or the variable name is changed, the
> code would break.
I use a #define because same value is used elsewhere in code.
> The use of malloc should also be avoided (unless the memory subsystem
> is not up yet; I haven't checked).
The malloc was part of the existing code, explained by comments.
-- Simon Riggs www.2ndQuadrant.comPostgreSQL Training, Services and Support