Re: Reorganize GUC structs

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Reorganize GUC structs
Дата
Msg-id 1227178.1762528495@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Reorganize GUC structs  (Peter Eisentraut <peter@eisentraut.org>)
Список pgsql-hackers
Peter Eisentraut <peter@eisentraut.org> writes:
> Here are a few more small patches to fix related things I found
> afterwards or in passing.

Looks sane, except that the comparator could do with an extra "const"
if there's enough room on the line:

+    const struct config_generic *ca = *(const struct config_generic *const *) a;
+    const struct config_generic *cb = *(const struct config_generic *const *) b;

Not essential, but casting const away even transiently looks ugly.

            regards, tom lane



В списке pgsql-hackers по дате отправления: