Re: [PATCHES] Infrastructure changes for recovery (v8)

On Mon, 2008-11-17 at 15:51 +0200, Heikki Linnakangas wrote:
> Simon Riggs wrote:
> > diff --git a/src/backend/access/transam/subtrans.c b/src/backend/access/transam/
> > index 063b366..5e64cb4 100644
> > --- a/src/backend/access/transam/subtrans.c
> > +++ b/src/backend/access/transam/subtrans.c
> > @@ -226,6 +226,9 @@ ZeroSUBTRANSPage(int pageno)
> >   *
> >   * oldestActiveXID is the oldest XID of any prepared transaction, or nextXid
> >   * if there are none.
> > + *
> > + * Note that this is not atomic and is not yet safe to perform while other
> > + * processes might access subtrans.
> >   */
> >  void
> >  StartupSUBTRANS(TransactionId oldestActiveXID)
> 
> I'm a bit confused by that comment. Does that need to be fixed? 

It is, in a later version. Apologies if you're reviewing the wrong one.

-- Simon Riggs           www.2ndQuadrant.comPostgreSQL Training, Services and Support