Re: [PATCH] Compressed TOAST data corruption with REPACK CONCURRENTLY

Antonin Houska <ah@cybertec.at> wrote:

> Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> > > ok, this is a patch to enhance the tests. It also simplifies
> > > gen_compressible() a bit and adjusts it so it is (hopefully) more reliable in
> > > generating compressible values. Now it can be used to reproduce the fix [1].
> > >
> > > [1] https://www.postgresql.org/message-id/52301.1776440752%40localhost
> >
> > Thanks, I think it looks good, but unfortunately I don't see any problems
> > when running this test without your fix (I was assuming that the test would
> > fail). I didn't immediately understand why.  Do you see any failures?
>
> The enhanced tests should reproduce it (please let me know if they dont):
>
> https://www.postgresql.org/message-id/44015.1776685220%40localhost

I see you actually refer to the correct tests. I see no failure now as
well. I'll try to make the tests more stable. Sorry for the confusion.

--
Antonin Houska
Web: https://www.cybertec-postgresql.com