Re: xact_desc

On Mon, 2008-10-13 at 23:05 -0400, Tom Lane wrote:
> Simon Riggs <simon@2ndQuadrant.com> writes:
> > ISTM that xact_desc routines do not work properly when called with
> > WAL_DEBUG enabled from XLogInsert().
> 
> Well, now that you mention it, that code is utterly, completely broken,
> and always has been.  It's passing only the first rdata-chunk of the WAL
> record to the print routine :-(
> 
> AFAICS the only way to fix it would be to allocate some workspace and
> assemble the chunks of the record into that.  Doubtful that it's worth
> it --- I'd be inclined to just remove the code instead.

Will remove, with extreme prejudice.

-- Simon Riggs           www.2ndQuadrant.comPostgreSQL Training, Services and Support