Re: Need more reviewers!

On Fri, 2008-09-05 at 09:19 -0400, Andrew Dunstan wrote:
> 
> Simon Riggs wrote:
> > On Thu, 2008-09-04 at 10:45 -0700, Josh Berkus wrote:
> >
> >   
> >> If you are a postgresql hacker at all, or even want to be one, we need your 
> >> help reviewing patches!  There are several "easy" patches in the list, so 
> >> I can assign them to beginners.  
> >>     
> >
> > It would be a reasonable rule that all patch submitters also have to do
> > patch reviews. If we made it a strict rule, then sponsoring companies
> > would know that they *must* provide money/time for that aspect also.
> > Otherwise it is almost impossible to get formal approval to do that.

> All this would do is to deter people from submitting patches. Hard rules 
> like this don't work in FOSS communities. I know it's like herding cats, 
> but persuasion is really our only tool.

I don't *want* the rule, I just think we *need* the rule because
otherwise sponsors/managers/etc make business decisions to exclude that
aspect of the software dev process.

Otherwise we have a patch-and-dump culture that is unsustainable because
a few people's benevolence as reviewers turns everything into a
bottleneck. It doesn't need to mean loss of control for core and
committers.

-- Simon Riggs           www.2ndQuadrant.comPostgreSQL Training, Services and Support