On Thu, 2008-03-20 at 23:07 +0000, Simon Riggs wrote:
> > Simon, would it be too much to ask that you concentrate on reviewing
> > existing patches during commit fest? Trying to get people to think
> > about random new ideas is about the most direct undermining of the
> > commit-fest concept that I can think of. Save 'em for later.
>
> That's a fair reminder, thanks, I will do that.
I'm a bit in the dark about this Commit Fest, to be honest.
Is this the list of patches to be reviewed?
http://wiki.postgresql.org/wiki/Todo:CommitFest
I was suspicious of that because it mentions "Minor changes to Recovery
related code" by Simon Riggs, which I'd already mentioned had been
committed more than 6 months ago.
ISTM that nobody has reviewed anything except you, Tom, from the list.
Is that true, or are there others working on reviews I can't see?
or maybe the patch list is this?
http://wiki.postgresql.org/wiki/Todo:PatchStatus
I'll review Tom Doran's and Dany DeBontridder's work.
Incidentally, I'm in favour of letting Heikki review his own work
because there's a backlog on index changes that appears to be months
long and he has a good chance of tackling that.
-- Simon Riggs 2ndQuadrant http://www.2ndQuadrant.com
PostgreSQL UK 2008 Conference: http://www.postgresql.org.uk