Re: SetBufferCommitInfoNeedsSave and race conditions

On Thu, 2007-06-28 at 15:29 -0400, Alvaro Herrera wrote:
> Tom Lane escribió:
> > Heikki Linnakangas <heikki@enterprisedb.com> writes:
> > > AFAICS, we can just simply remove the assertion. But is there any
> > > codepaths that assume that after calling HeapTupleSatisfiesSnapshot, all
> > > appropriate hint bits are set?
> >
> > There had better not be, since we are going to postpone setting hint
> > bits for recently-committed transactions as part of the async-commit
> > patch.
> >
> > A quick grep suggests that VACUUM FULL might be at risk here.
>
> That particular case seems easily fixed since VACUUM FULL must hold an
> exclusive lock; and we can forcibly set sync commit for VACUUM FULL.

Exactly what it does!

--  Simon Riggs              EnterpriseDB   http://www.enterprisedb.com