Re: SetBufferCommitInfoNeedsSave and race conditions

Поиск
Список
Период
Сортировка
От Simon Riggs
Тема Re: SetBufferCommitInfoNeedsSave and race conditions
Дата
Msg-id 1183068576.3589.5.camel@silverbirch.site
обсуждение исходный текст
Ответ на Re: SetBufferCommitInfoNeedsSave and race conditions  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: SetBufferCommitInfoNeedsSave and race conditions  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On Thu, 2007-06-28 at 15:16 -0400, Tom Lane wrote:
> Heikki Linnakangas <heikki@enterprisedb.com> writes:
> > AFAICS, we can just simply remove the assertion. But is there any 
> > codepaths that assume that after calling HeapTupleSatisfiesSnapshot, all 
> > appropriate hint bits are set?
> 
> There had better not be, since we are going to postpone setting hint
> bits for recently-committed transactions as part of the async-commit
> patch.
> 
> A quick grep suggests that VACUUM FULL might be at risk here.

No we're clear: I caught that issue specifically for VACUUM FULL fairly
early on. VF assumes all hint bits are set after the first scan, so we
flush prior to the scan to ensure its safe to set the hint bits. There
are no concurrent hint bit setters, so we are good.

--  Simon Riggs              EnterpriseDB   http://www.enterprisedb.com




В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: lazy vacuum sleeps with exclusive lock on table
Следующее
От: "Simon Riggs"
Дата:
Сообщение: Re: lazy vacuum sleeps with exclusive lock on table