Re: pgsql crollable cursor doesn't support one form of postgresql's cu
| От | Neil Conway |
|---|---|
| Тема | Re: pgsql crollable cursor doesn't support one form of postgresql's cu |
| Дата | |
| Msg-id | 1177650074.6440.77.camel@localhost.localdomain обсуждение исходный текст |
| Ответ на | Re: pgsql crollable cursor doesn't support one form of postgresql's cu (Bruce Momjian <bruce@momjian.us>) |
| Ответы |
Re: pgsql crollable cursor doesn't support one form ofpostgresql's cu
|
| Список | pgsql-hackers |
I haven't read the rest of the thread yet, but is this hunk not buggy?
yylex() is side-effecting, so the two calls to yylex() do not do what
the comment suggests.
> *** 2083,2091 ****
> check_FROM = false;
> }
>
> ! /* check FROM keyword after direction's specification */
> ! if (check_FROM && yylex() != K_FROM)
> ! yyerror("expected \"FROM\"");
>
> return fetch;
> }
> --- 2089,2097 ----
> check_FROM = false;
> }
>
> ! /* check FROM or IN keyword after direction's specification */
> ! if (check_FROM && (yylex() != K_FROM && yylex() != K_IN))
> ! yyerror("expected \"FROM/IN\"");
>
> return fetch;
-Neil
В списке pgsql-hackers по дате отправления: