Magnus Hagander <magnus@hagander.net> writes:
> The attached patch seems to fix the build issue. Does it seem
> acceptable/the right thing to do?
No, it seems pretty bletcherous.
> Another option would be to just reject both 2.0 and 2.1 as broken to
> build pg with, I guess...
In bison 2.3 (which is shipping with Fedora Core 6), all the uses of
__STDC__ seem to also test _MSC_VER:
#if (defined __STDC__ || defined __C99__FUNC__ \ || defined __cplusplus || defined _MSC_VER)
If this fixes the problem, then I'd vote for just stating you need
bison >= 2.3 (or 2.2?) to build on MSVC.
regards, tom lane