Re: Time to read pg_hba.conf (Re: [PATCHES] [PATCH] Patch to make...)

Peter Eisentraut <peter_e@gmx.net> writes:
> So we're looking at a possible 12% win.

Many thanks for doing this legwork.

The possible win from not having to read the file at all is probably
somewhat higher than that, but not vastly higher.  Accordingly, I'd
say that pre-parsing the file is not worth the development time needed
to make it happen.  However, moving the comments out is clearly worth
the (very small) amount of effort needed to make that happen.  Any
objections?

> Btw., in case someone wants to go optimizing, more than 75% of the backend
> startup time is spent in InitPostgres():

No surprise, that's where all the initial database access happens.  We'd
need to break it down more to learn anything useful, but I'd bet that
the initial loading of required catalog cache entries is a big chunk.
        regards, tom lane