Re: TM formating patch

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: TM formating patch
Дата
Msg-id 116.1170691348@sss.pgh.pa.us
обсуждение исходный текст
Ответ на TM formating patch  ("Pavel Stehule" <pavel.stehule@hotmail.com>)
Список pgsql-patches
"Pavel Stehule" <pavel.stehule@hotmail.com> writes:
> This patch correct bug, when localized day or month names was incorectly
> trnasformed to lower or upper string.

I really dislike the API you've chosen for upper_str/lower_str ---
overwriting the input on the assumption that it's long enough is a
buffer overrun bug waiting to happen, because (at least in utf8)
changing case doesn't preserve the byte length of the string.
Please make them return a freshly palloc'd string instead.

            regards, tom lane

В списке pgsql-patches по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: [pgsql-patches] Phantom Command IDs, updated patch
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: [pgsql-patches] [GENERAL] Corrupt database? 8.1/FreeBSD6.0